[U-Boot] [PATCH 08/12] ARM: socfpga: use "select" instead of default value in defconfig

Masahiro Yamada yamada.masahiro at socionext.com
Thu Apr 2 02:30:50 CEST 2015


Hi Pavel,

2015-04-01 5:40 GMT+09:00 Pavel Machek <pavel at denx.de>:
> Hi!
> On Tue 2015-03-31 12:47:59, Masahiro Yamada wrote:
>> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>> ---
>>
>>  arch/arm/Kconfig                   | 6 ++++++
>>  configs/socfpga_arria5_defconfig   | 3 ---
>>  configs/socfpga_cyclone5_defconfig | 3 ---
>>  configs/socfpga_socrates_defconfig | 3 ---
>>  4 files changed, 6 insertions(+), 9 deletions(-)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index b25a4a9..6ae48c6 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -618,11 +618,17 @@ config TARGET_SOCFPGA_ARRIA5
>>       bool "Support socfpga_arria5"
>>       select CPU_V7
>>       select SUPPORT_SPL
>> +     select DM
>> +     select DM_SPI_FLASH
>> +     select DM_SPI
>>
>
> Are you sure?


Yes, I'm sure.

> config DM_SPI_FLASH
>         bool "Enable Driver Model for SPI flash"
>         depends on DM && SPI
>                 help
>
> DM_SPI_FLASH depends on SPI, you can't just select it...
>


This dependency is wrong.
Before this patch, it must be fixed.

Please see 01/12 of this series:
http://patchwork.ozlabs.org/patch/456458/


-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list