[U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing
Lukasz Majewski
l.majewski at samsung.com
Fri Apr 3 09:35:00 CEST 2015
Hi Marek,
> On Monday, March 30, 2015 at 10:06:13 AM, Lukasz Majewski wrote:
> > Hi Paul,
> >
> > > Signed-off-by: Paul Kocialkowski <contact at paulk.fr>
> > > ---
> > >
> > > common/cmd_fastboot.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> > > index 346ab80..7956a5b 100644
> > > --- a/common/cmd_fastboot.c
> > > +++ b/common/cmd_fastboot.c
> > > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int
> > > flag, int argc, char *const argv[]) if
> > > (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not
> > > detected.\n" \
> > >
> > > "Command exit.\n");
> > >
> > > + g_dnl_unregister();
> > > + g_dnl_clear_detach();
> > >
> > > return CMD_RET_FAILURE;
> > >
> > > }
> >
> > This is just a minor comment - in your future patches please add
> > some commit message even for this very short patch.
> >
> > Despite that,
> >
> > Acked-by: Lukasz Majewski <l.majewski at samsung.com>
> >
> > If other (Marek, Tom) don't mind I will take this through -dfu tree.
>
> Please do, thanks!
>
> btw. is this for current or next release ?
>
> Best regards,
> Marek Vasut
I thought to add this code in the next merge window, since now we have
-rc5.
The v2015.04 is scheduled for 13.04.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
More information about the U-Boot
mailing list