[U-Boot] [PATCH v3] MAKEALL: fix get_target_arch() to adjust to '-' in Status field

Masahiro Yamada yamada.masahiro at socionext.com
Mon Apr 6 04:12:28 CEST 2015


Since the Kconfig conversion, boards.cfg scanned by MAKEALL is
generated by tools/genboardscfg.py.  Every board is supposed to have
its own MAINTAINERS that contains maintainer and status information,
but, in fact, MAINTAINERS is missing from some boards.

For such boards, the first field, Status, is filled with '-'.
It causes a problem for "set" command, which ignores '-' in its
arguments.  Consequently, get_target_arch() returns a wrong field
and MAKEALL fails to get a correct toolchain.

Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
---

Changes in v3:
  - Fix commit description

Changes in v2:
  - Improve git description

 MAKEALL | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/MAKEALL b/MAKEALL
index cd3b6c7..3808a59 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -551,13 +551,7 @@ get_target_maintainers() {
 get_target_arch() {
 	local target=$1
 
-	# Automatic mode
-	local line=`awk '\$7 == "'"$target"'" { print \$0 }' boards.cfg`
-
-	if [ -z "${line}" ] ; then echo "" ; return ; fi
-
-	set ${line}
-	echo "$2"
+	awk '$7 == "'$target'" { print $2 }' boards.cfg
 }
 
 list_target() {
-- 
1.9.1



More information about the U-Boot mailing list