[U-Boot] [PATCH v2] MAKEALL: fix get_target_arch() to adjust to '-' in Status field

Simon Glass sjg at chromium.org
Mon Apr 6 05:25:38 CEST 2015


Hi Masahiro,

On 5 April 2015 at 21:08, Masahiro Yamada <yamada.masahiro at socionext.com> wrote:
>
> Hi Simon, Tom,
>
>
> 2015-04-06 3:31 GMT+09:00 Simon Glass <sjg at chromium.org>:
> > Hi Tom,
> >
> > On 1 April 2015 at 05:19, Tom Rini <trini at konsulko.com> wrote:
> >> On Tue, Mar 31, 2015 at 08:39:57PM -0600, Simon Glass wrote:
> >>
> >>> Hi Masahiro,
> >>>
> >>> On 30 March 2015 at 05:59, Masahiro Yamada
> >>> <yamada.masahiro at socionext.com> wrote:
> >>> > Since the Kconfig conversion, boards.cfg scanned by MAKEALL is
> >>> > generated by tools/genboardscfg.py.  Every board is supposed to have
> >>> > its own MAINTAINERS that contains maintainer and status information,
> >>> > but, in fact, MAINTAINERS is missing from some boards.
> >>> >
> >>> > For such boards, the first field, Status, is filled with '-'.
> >>> > It causes a problem for "set" command, which ignores '-' in its
> >>> > arguments.  Consequently, get_target_arch() returns a wrong field
> >>> > and MAKEALL fails to get a correct toolchain.
> >>> >
> >>> > Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> >>> >   - Improve git description
> >>>
> >>> Should we perhaps apply the patch to deprecate MAKEALL?
> >>
> >> With the last patch I posted about what binaries to save all my usecases
> >> are covered now.
> >
> > OK, do you think we can wait until the merge window before doing
> > these? I don't see any great hurry.
> >
>
> I know MAKEALL is deprecated, but I still use it with a local-hack to
> compare MD5SUM.
>
> Buildman is a bigger program than MAKEALL and I have not been able to
> find time to
> dig into it.
>
> The above is my personal reason, but this patch is an apparent bug-fix
> and it is easy enough.
> Why don't we fix it?

I wan't suggesting we don't fix it! I agree you patch is a good thing
- it just jogged my memory about MAKEALL deprecation.

Regards,
Simon


More information about the U-Boot mailing list