[U-Boot] [PATCH] usb: hub: allow pgood_delay to be specified via env

[Tim Harvey]

On Mon, Apr 6, 2015 at 7:58 AM, Marek Vasut <marex at denx.de> wrote:
> On Monday, April 06, 2015 at 04:05:07 PM, Tim Harvey wrote:
>> Some USB devices break the spec and require longer warm-up times. Allow
>> the usb_pgood_delay env variable to override the calculated time.
>>
>> I have encountered this specficically with several different sized/branded
>> USB sticks with VID:PID 058f:6387 (Alcor Micro Corp. Transcend JetFlash)
>> where I need to set usb_pgood_delay to 2000ms to make them detectable.
>>
>> Signed-off-by: Tim Harvey <tharvey at gateworks.com>
>
> Hi!
>
> this looks like a good idea. I have a hint for improvement -- in case you
> get a timeout waiting for the device to be detected, maybe the error message
> should mention that you can try setting this env variable and try again ?
>
> Best regards,
> Marek Vasut

Marek,

I'm not sure what 'failed detect' would be appropriate though. In my
case I was dealing with storage devices so I think what you are
proposing is that on a 'usb start' if 0 storage devices are found
display a message such as:

No storage devices found - if a connected device is not being detected
try setting usb_pgood_delay env var to something above the 1000ms time
the USB spec allows

Sounds a bit verbose and I'm not clear if it should be limited to USB
storage devices or other supported devices (I'm betting its just the
storage ones that often break the spec).

Stephen, what do you think? You and I discussed adding such an env var
about a year ago.

Tim