[U-Boot] [PATCH v2] usb: hub: allow pgood_delay to be specified via env

Tim Harvey tharvey at gateworks.com
Wed Apr 8 21:21:12 CEST 2015


Some USB devices break the spec and require longer warm-up times. Allow
the usb_pgood_delay env variable to override the calculated time.

Signed-off-by: Tim Harvey <tharvey at gateworks.com>
---
v2:
 - added cast to fix compiler warning
---
 common/usb_hub.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/common/usb_hub.c b/common/usb_hub.c
index 66b4a72..f54a404 100644
--- a/common/usb_hub.c
+++ b/common/usb_hub.c
@@ -86,6 +86,7 @@ static void usb_hub_power_on(struct usb_hub_device *hub)
 	int i;
 	struct usb_device *dev;
 	unsigned pgood_delay = hub->desc.bPwrOn2PwrGood * 2;
+	const char *env;
 
 	dev = hub->pusb_dev;
 
@@ -98,7 +99,14 @@ static void usb_hub_power_on(struct usb_hub_device *hub)
 	/*
 	 * Wait for power to become stable,
 	 * plus spec-defined max time for device to connect
+	 * but allow this time to be increased via env variable as some
+	 * devices break the spec and require longer warm-up times
 	 */
+	env = getenv("usb_pgood_delay");
+	if (env)
+		pgood_delay = max(pgood_delay,
+			          (unsigned)simple_strtol(env, NULL, 0));
+	debug("pgood_delay=%dms\n", pgood_delay);
 	mdelay(pgood_delay + 1000);
 }
 
-- 
1.9.1



More information about the U-Boot mailing list