[U-Boot] [PATCH v2 0/6] Add support for Colibri Vybrid Modules

Marek Vasut marex at denx.de
Mon Apr 13 01:28:07 CEST 2015


On Sunday, April 12, 2015 at 07:33:41 AM, maitysanchayan at gmail.com wrote:
> Hi,
> 
> On 15-04-11 18:46:15, Marek Vasut wrote:
> > On Wednesday, April 08, 2015 at 03:20:04 PM, Sanchayan Maity wrote:
> > > Hello,
> > > 
> > > This is the second version of the patchset which adds support for the
> > > Toradex Colibri Vybrid VF50 and VF61 modules. Boot up has been tested
> > > using the serial loader over UART.
> > 
> > Hi!
> > 
> > Stefano, maybe you can pick 1,2,3,4,6 right away for next? This way, we
> > can solve 5/6 separately, since it might need some further dicussion. I
> > don't want that patch to block the rest of the series though.
> 
> The sixth patch has some minor dependencies on the fifth patch like some
> #defines and configuration we enable for Colibri. In case the fifth
> patch will require some more discussion and time, then I guess I will
> need to rework the sixth patch and then everything related to USB can
> go in a later patch. The rework will be minor. So the v3 will be without
> USB support

Well, if you want to rework the 6th patch, that'd be very nice of you :)

> and USB will go in later once this gets applied. Perhaps we
> will send the USB along with some more other featureset addition like
> gpio support for Vybrid which my colleague did recently along with some
> driver model/dt stuff.

My impression is that the USB is just a matter of figuring out where the
PHY registers go -- whether in arch/arm/include/imx-common or into
include/usb/ . I'd be more inclined for the later, since the PHY regs
looks like chipidea IP specific thing, but I might be wrong.

> By the way, where the fifth patch is concerned, is it related to the
> discussion Fabio pointed out in the discussion on first version of the
> patch? uboot trying to get rid of the 'no register access via offset'
> rule? Anything required I can rework accordingly.

I was concerned about the placement of the PHY reg definition. I didn't
hear from Fabio on the result of this decision and I don't really mind
that either way.

Best regards,
Marek Vasut


More information about the U-Boot mailing list