[U-Boot] [PATCH v2 5/6] usb: host: Add ehci-vf USB driver for ARM Vybrid SoC's

[maitysanchayan at gmail.com]

Hello,

On 15-04-13 01:29:39, Marek Vasut wrote:
> On Wednesday, April 08, 2015 at 03:20:09 PM, Sanchayan Maity wrote:
> > This driver adds support for the USB peripheral on Freescale Vybrid
> > SoC's.
> > 
> > Signed-off-by: Sanchayan Maity <maitysanchayan at gmail.com>
> > ---
> >  arch/arm/include/asm/arch-vf610/crm_regs.h    |  10 ++
> >  arch/arm/include/asm/arch-vf610/imx-regs.h    |   4 +
> >  arch/arm/include/asm/arch-vf610/regs-usbphy.h |  31 ++++
> >  drivers/usb/host/Makefile                     |   1 +
> >  drivers/usb/host/ehci-vf.c                    | 196
> > ++++++++++++++++++++++++++ 5 files changed, 242 insertions(+)
> >  create mode 100644 arch/arm/include/asm/arch-vf610/regs-usbphy.h
> >  create mode 100644 drivers/usb/host/ehci-vf.c
> 
> A general hint, you can replace sequences of code like this:
> 
> var = readl(foo);
> var |= BIT_BAR;
> writel(var, addr);
> 
> with
> 
> setbits_le32(var, BIT_BAR);
> 
> Same applies for clearing -- clrbits_le32() and both setting and
> clearing -- clrsetbits_le32().

Sorry about that. It is something which I use in the sixth patch 
as well in the board files but it skipped my mind while doing this 
driver. Will take care of it in v3 which seems imminent.

Noted, thanks :).

- Sanchayan.

> 
> Thanks!
> 
> Best regards,
> Marek Vasut