[U-Boot] Testing u-boot-dm/next

[Simon Glass]

Hi Bin,

On 11 April 2015 at 07:48, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Sat, Apr 11, 2015 at 9:22 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Hi Simon,
>>
>> On Sat, Apr 11, 2015 at 1:42 AM, Simon Glass <sjg at chromium.org> wrote:
>>> Hi Bin,
>>>
>>> On 9 April 2015 at 06:52, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>> Hi Simon,
>>>>
>>>> On Thu, Apr 9, 2015 at 11:11 AM, Simon Glass <sjg at chromium.org> wrote:
>>>>> (Correcting address for Masahiro, sorry)
>>>>>
>>>>>
>>>>> On 8 April 2015 at 21:07, Simon Glass <sjg at chromium.org> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I have quite a few patches queued up in the next branch of u-boot-dm,
>>>>>> ready for when the merge window options.
>>>>>>
>>>>>> If anyone has time and can give it a spin on their board, it would be much
>>>>>> appreciated!
>>>>>>
>>>>>> Regards,
>>>>>> Simon
>>>>>>
>>>>
>>>> I've tested it on CrownBay board and found one issue:
>>>>
>>>> During the boot up, or typing 'sf probe' in the U-Boot shell, it reports:
>>>>
>>>> Invalid bus 0 (err=-19)
>>>>
>>>> I have not investigated but suspect this is due to the CrownBay board
>>>> has not been converted to use DM SPI, like Chromebook?
>>>
>>> All of x86 should use that - it is in arch/x86/Kconfig.
>>
>> Ah, I see.
>>
>>> More likely the SPI compatible string is wrong:
>>>
>>> compatible = "intel,ich7";
>>>
>>> It should be "intel,ich-spi "I think. You can check with 'dm tree' to
>>> see what devices have been found.
>>
>> But changing crownbay.dts to use "intel,ich-spi" does not help.
>>
>> => dm tree
>>  Class       Probed   Name
>> ----------------------------------------
>>  root        [ + ]    root_driver
>>  serial      [ + ]    |-- serial
>>  gpio        [   ]    |-- gpioa
>>  gpio        [   ]    |-- gpiob
>>  spi         [   ]    `-- spi
>>  spi_flash   [   ]        `-- spi-flash at 0
>> => sf probe
>> Invalid bus 0 (err=-19)
>> Failed to initialize SPI flash at 0:0 (error -19)
>>
>
> 'git besect' shows that commit 898ed91 breaks the things.
>
> A debug version of U-Boot log is:
>
> => sf probe
> uclass_find_device_by_seq: 0 0
>    - -1 -1
>    - not found
> spi_find_bus_and_cs: No bus 0
> uclass_find_device_by_seq: 0 0
>    - -1 -1
>    - not found
> uclass_find_device_by_seq: 1 0
>    - -1 -1
>    - not found
> Invalid bus 0 (err=-19)
> Failed to initialize SPI flash at 0:0 (error -19)
> Command failed, result=1=>

With the conversion to driver model it no-longer probes the PCI bus
looking for a SPI device. Did you try adding and alias too? I think
you fixed the compatible string.

I have tested this again on link and it seems OK there (there is an
unrelated problem with coreboot not supporting the pch and so not
seeing SPI which I will look at).

Since you have a SPI bus device, and its sequence number appears to be
unset, it should just be a case of sorting that out.

Can you send the output of 'dm uclass'.

Regards,
Simon