[U-Boot] [PATCH v3 1/3] dm: usb: Move descriptor setup code into its own function

Marek Vasut marex at denx.de
Tue Apr 14 05:56:01 CEST 2015


On Tuesday, April 14, 2015 at 05:19:02 AM, Simon Glass wrote:
> usb_new_device() is far too long and does far too much. As a first step,
> move the code that does initial setup and reads a descriptor into its own
> function called usb_setup_descriptor().
> 
> For XHCI the init order is different - we set up the device but don't
> actually read the descriptor until after we set an address. Support this
> option as a parameter to usb_setup_descriptor().
> 
> Avoid changing this torturous code more than necessary to make it easy to
> review.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

Reviewed-by: Marek Vasut <marex at denx.de>

Best regards,
Marek Vasut


More information about the U-Boot mailing list