[U-Boot] [PATCH v2 3/4] mtd: nand: mxs: Add comment for calculating ECC strength

Heiko Schocher hs at denx.de
Tue Apr 14 08:12:53 CEST 2015


Hello Jörg,

Am 13.04.2015 22:17, schrieb Jörg Krause:
> Signed-off-by: Jörg Krause <joerg.krause at embedded.rocks>
> ---
>   drivers/mtd/nand/mxs_nand.c | 7 +++++++
>   1 file changed, 7 insertions(+)

nitpick only ...

> diff --git a/drivers/mtd/nand/mxs_nand.c b/drivers/mtd/nand/mxs_nand.c
> index 912fed8..76e47ab 100644
> --- a/drivers/mtd/nand/mxs_nand.c
> +++ b/drivers/mtd/nand/mxs_nand.c
> @@ -148,6 +148,13 @@ static inline uint32_t mxs_nand_get_ecc_strength(uint32_t page_data_size,
>   {
>   	int ecc_strength;
>
> +	/* Determine the ECC layout with the formula:

wrong comment style ... please fix also in patch 4/4... thanks.

bye,
Heiko
> +	 * 	ECC bits per chunk = (total page spare data bits) /
> +	 * 		(bits per ECC level) / (chunks per page)
> +	 * where:
> +	 * 	total page spare data bits =
> +	 * 		(page oob size - meta data size) * (bits per byte)
> +	 */
>   	ecc_strength = ((page_oob_size - MXS_NAND_METADATA_SIZE) * 8)
>   			/ (MXS_NAND_BITS_PER_ECC_LEVEL *
>   				mxs_nand_ecc_chunk_cnt(page_data_size));
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list