[U-Boot] [RESEND PATCH v4 2/3] mtd, nand: move common functions from cmd_nand.c to common place

Heiko Schocher hs at denx.de
Tue Apr 14 08:21:19 CEST 2015


Hello Scott,

Am 13.04.2015 22:32, schrieb Scott Wood:
> On Sun, 2015-04-12 at 10:12 +0200, Heiko Schocher wrote:
>> @@ -595,7 +491,10 @@ static int do_nand(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>>   		printf("\nNAND %s: ", cmd);
>>   		/* skip first two or three arguments, look for offset and size */
>>   		if (arg_off_size(argc - o, argv + o, &dev, &off, &size,
>> -				 &maxsize) != 0)
>> +		    &maxsize, MTD_DEV_TYPE_NAND, nand_info[dev].size) != 0)
>
> Please keep the continuation line aligned with the arguments, not the
> function name (here and elsewhere).

Good catch! Fixed. Wait for more comments before posting v5 ...

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list