[U-Boot] [PATCH v2 10/13] arm: mvebu: Add dynamic SoC detection to mbus driver

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Apr 14 17:31:05 CEST 2015


Dear Stefan Roese,

On Tue, 14 Apr 2015 12:46:52 +0200, Stefan Roese wrote:

> +			if (mvebu_soc_family() == MVEBU_SOC_AXP)
> +				w->mbus_attr |= ATTR_HW_COHERENCY;

Why is this Armada XP specific? Both Armada XP and Armada 38x support
HW I/O coherency. But are you actually using HW I/O coherency in U-Boot
for Armada XP ?

It would probably be simpler to not use HW I/O coherency at all in
U-Boot, be it for AXP or A38x.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the U-Boot mailing list