[U-Boot] [PATCH v3 1/3] dm: usb: Move descriptor setup code into its own function

Simon Glass sjg at chromium.org
Tue Apr 14 20:05:17 CEST 2015


Hi Stephen,

On 14 April 2015 at 08:56, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 04/13/2015 09:19 PM, Simon Glass wrote:
>>
>> usb_new_device() is far too long and does far too much. As a first step,
>> move
>> the code that does initial setup and reads a descriptor into its own
>> function
>> called usb_setup_descriptor().
>>
>> For XHCI the init order is different - we set up the device but don't
>> actually read the descriptor until after we set an address. Support this
>> option as a parameter to usb_setup_descriptor().
>>
>> Avoid changing this torturous code more than necessary to make it easy to
>> review.
>
>
> The series,
>
> Tested-by: Stephen Warren <swarren at nvidia.com>
>
> Note that what I actually tested was the commits in u-boot-dm/next, which in
> another email you mentioned included these patches.

That's right. Thanks - I'll work on getting a pull request for this lot soon.

Regards,
Simon


More information about the U-Boot mailing list