[U-Boot] [UBOOT PATCH] f_thor: Dont perform reset at the end of thor

[Michal Simek]

Hi Marek,

2014-09-24 14:33 GMT+02:00 Michal Simek <monstr at monstr.eu>:

> On 09/05/2014 09:01 AM, Siva Durga Prasad Paladugu wrote:
> > Dont perform reset at the end of thor download
> > if configured to do reset off.
> > Reset may not be required in all cases and hence
> > provided an option to do so.
> >
> > Signed-off-by: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
> > ---
> >  drivers/usb/gadget/f_thor.c |    7 +++++++
> >  drivers/usb/gadget/f_thor.h |    3 +++
> >  2 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/f_thor.c b/drivers/usb/gadget/f_thor.c
> > index c85b0fb..8cf0718 100644
> > --- a/drivers/usb/gadget/f_thor.c
> > +++ b/drivers/usb/gadget/f_thor.c
> > @@ -123,6 +123,9 @@ static int process_rqt_cmd(const struct rqt_box *rqt)
> >               send_rsp(rsp);
> >               g_dnl_unregister();
> >               dfu_free_entities();
> > +#ifdef CONFIG_THOR_RESET_OFF
> > +             return RESET_DONE;
> > +#endif
> >               run_command("reset", 0);
> >               break;
> >       case RQT_CMD_POWEROFF:
> > @@ -726,6 +729,10 @@ int thor_handle(void)
> >
> >               if (ret > 0) {
> >                       ret = process_data();
> > +#ifdef CONFIG_THOR_RESET_OFF
> > +                     if (ret == RESET_DONE)
> > +                             break;
> > +#endif
> >                       if (ret < 0)
> >                               return ret;
> >               } else {
> > diff --git a/drivers/usb/gadget/f_thor.h b/drivers/usb/gadget/f_thor.h
> > index 833a9d2..8341285 100644
> > --- a/drivers/usb/gadget/f_thor.h
> > +++ b/drivers/usb/gadget/f_thor.h
> > @@ -121,4 +121,7 @@ struct f_thor {
> >  #define F_NAME_BUF_SIZE 32
> >  #define THOR_PACKET_SIZE SZ_1M      /* 1 MiB */
> >  #define THOR_STORE_UNIT_SIZE SZ_32M /* 32 MiB */
> > +#ifdef CONFIG_THOR_RESET_OFF
> > +#define RESET_DONE 0xFFFFFFFF
> > +#endif
> >  #endif /* _USB_THOR_H_ */
> >
>
> Tested-by: Michal Simek <monstr at monstr.eu>
>
> It is reasonable config option not to reset the board after every download.
>
> Thanks,
> Michal
>
>
Any comment on this one?

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform