[U-Boot] [PATCH] net: Use u32 instead of ulong for transaction ID in bootp

Thierry Reding treding at nvidia.com
Wed Apr 15 14:04:04 CEST 2015


On Wed, Apr 15, 2015 at 12:50:59PM +0200, Michal Simek wrote:
> From: Siva Durga Prasad Paladugu <siva.durga.paladugu at xilinx.com>
> 
> Based on rfc951 transaction ID has 4 bytes which is not the case when
> ulong type is used on ARM64.
> Use u32 type which is well defined for all archs.
> 
> BOOTP_VENDOR_MAGIC is also 4 bytes.
> 
> Based on RFC1048 Time Offset (code 2) is also 4bytes long
> and IP Address Lease Time also.
> 
> The patch converts NetCopyLong to netcopy32 and NetReadLong to netread32
> to follow u-boot coding style.
> 
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---
> 
>  include/net.h | 14 +++++++-------
>  net/bootp.c   | 18 +++++++++---------
>  net/bootp.h   |  2 +-
>  3 files changed, 17 insertions(+), 17 deletions(-)

Looks reasonable to me:

Reviewed-by: Thierry Reding <treding at nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150415/415327c0/attachment.sig>


More information about the U-Boot mailing list