[U-Boot] [PATCH V4 06/10] dm: core: uclass: add function: uclass_find_device_by_name()
Simon Glass
sjg at chromium.org
Mon Apr 20 05:22:54 CEST 2015
On 19 April 2015 at 07:23, Simon Glass <sjg at chromium.org> wrote:
> Hi Przemyslaw,
>
> On 15 April 2015 at 05:07, Przemyslaw Marczak <p.marczak at samsung.com> wrote:
>> This commit extends the driver model uclass's API by function:
>> - uclass_find_device_by_name()
>>
>> And this function returns the device if:
>> - uclass with given ID, exists,
>> - device with exactly given name(dev->name), exists.
>>
>> The returned device is not activated - need to be probed before use.
>>
>> Note:
>> This function returns the first device, which name is equal
>> to the given one. This means, that using this function you must
>> assume, that the device name is unique in the given uclass's ID
>> device list.
>>
>> uclass-internal.h: cleanup - move the uclass_find_device_by_seq()
>> declaration and description, near the other uclass_find*() functions.
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak at samsung.com>
>> Cc: Simon Glass <sjg at chromium.org>
>
> This uses strncmp() so I thing the function comment should say that it
> searches only for the part of the name provided. But I suppose this is
> a minor point.
>
> Acked-by: Simon Glass <sjg at chromium.org>
>
> Regards,
> Simon
Applied to u-boot-dm, thanks!
More information about the U-Boot
mailing list