[U-Boot] [PATCH] x86: galileo: Define mac addresses for the on-chip ethernet ports

[Joe Hershberger]

Hi Bin Meng,

On Tue, Apr 21, 2015 at 8:54 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 20 April 2015 at 23:05, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Not like other x86 chipset, there is no EEPROM for the ethernet
>> controller on the Intel Quark SoC to retreive the mac address
>> after power up. With pre-defined mac addresses, U-Boot boots up
>> and will not show "Error: dwmac.90006000 address not set" message.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>>  include/configs/galileo.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/include/configs/galileo.h b/include/configs/galileo.h
>> index d4d0eb3..961d087 100644
>> --- a/include/configs/galileo.h
>> +++ b/include/configs/galileo.h
>> @@ -62,6 +62,8 @@
>>  #define CONFIG_DESIGNWARE_ETH
>>  #define CONFIG_DW_ALTDESCRIPTOR
>>  #define CONFIG_PHYLIB
>> +#define CONFIG_ETHADDR         00:02:b3:00:00:00
>> +#define CONFIG_ETH1ADDR                00:02:b3:00:00:01
>
> I recall this coming up before with another board - we are not
> supposed to set a default MAC address since it may create inexplicable
> conflicts on the network if an org two boards on the same network one
> day. Can you just set an environment variable?

Simon is correct here. You should simply set it in your environment on
your board. Another option that we tend to frown on, but is allowed,
is to call net_random_ethaddr() from your board init.

-Joe