[U-Boot] [PATCH 3/4] include:configs:ls1021atwr: Enable USB IP support

[Marek Vasut]

On Thursday, April 23, 2015 at 08:51:14 AM, Ramneek Mehresh wrote:
> > -----Original Message-----
> > From: Marek Vasut [mailto:marex at denx.de]
> > Sent: Wednesday, April 22, 2015 5:18 PM
> > To: Mehresh Ramneek-B31383
> > Cc: u-boot at lists.denx.de
> > Subject: Re: [PATCH 3/4] include:configs:ls1021atwr: Enable USB IP
> > support
> > 
> > On Wednesday, April 22, 2015 at 08:49:42 AM, Ramneek Mehresh wrote:
> > > Enable USB IP support for both EHCI and XHCI for ls1021atwr platform
> > > 
> > > Signed-off-by: Ramneek Mehresh <ramneek.mehresh at freescale.com>
> > > ---
> > > 
> > >  include/configs/ls1021atwr.h | 29 +++++++++++++++++++++++++++++
> > > 
> > > include/linux/usb/xhci-fsl.h |  5 +++++
> > > 
> > >  2 files changed, 34 insertions(+)
> > > 
> > > diff --git a/include/configs/ls1021atwr.h
> > > b/include/configs/ls1021atwr.h index a13876b..0f59b3c 100644
> > > --- a/include/configs/ls1021atwr.h
> > > +++ b/include/configs/ls1021atwr.h
> > > @@ -28,6 +28,35 @@
> > > 
> > >  #define CONFIG_SYS_INIT_RAM_SIZE	OCRAM_SIZE
> > >  
> > >  /*
> > > 
> > > + * USB
> > > + */
> > > +/* EHCI Support - disbaled by default */
> > 
> > 'disabled'
> > 
> > > +/*#define CONFIG_HAS_FSL_DR_USB*/
> > 
> > Why is this disabled ?
> 
> EHCI is disabled because this controller is not exposed via any connector
> on the board. However, the silicon still has this controller, and anyone
> can use this controller by taking signals out on their board.
> XHCI can be used on the board via micro-A usb host connector

Oki, please document it a bit better. The thing you just wrote would be exactly
the nice piece of documentation/comment which should be in the code.

Thanks!

Best regards,
Marek Vasut