[U-Boot] [PATCH v4 11/16] dm: regulator: add fixed voltage regulator driver

Simon Glass sjg at chromium.org
Fri Apr 24 06:50:38 CEST 2015


Hi Przemyslaw,

On 23 April 2015 at 06:31, Przemyslaw Marczak <p.marczak at samsung.com> wrote:
> Hello Simon,
>
> On 04/20/2015 08:07 PM, Przemyslaw Marczak wrote:
>>
>> This driver implements regulator operations for fixed Voltage/Current
>> value regulators. beside the standard regulator constraints, which are
>> put into the uclass platform data, a typical fixed regulator node provides
>> few additional properties like:
>> - gpio
>> - gpio-open-drain
>> - enable-active-high
>> - startup-delay-us
>> The only 'gpio' is used by this driver and is kept in structure of type
>> 'fixed_regulator_platdata', as a device platform data (dev->platdata).
>>
>> The driver implements:
>> - get_value
>> - get_current
>> - get_enable
>> - set_enable
>>
>> The regulator calls and commands can be used for fixed-regulator devices,
>> and the proper error will be returned for prohibited.
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak at samsung.com>
>>
>
> I missed the separation (---) here and I see that you add ACK below the
> changes.
> Could you remove them from the tree?

OK, done. You could try patman which handles this automatically.

Regards,
Simon


More information about the U-Boot mailing list