[U-Boot] [PATCH 1/2] spl: spl_mmc: Clearer structure in spl_mmc_load_image and cosmetics

[Paul Kocialkowski]

Le mardi 21 avril 2015 à 09:32 -0400, Tom Rini a écrit :
> On Sun, Apr 19, 2015 at 09:30:08PM +0200, Paul Kocialkowski wrote:
> 
> > This refactors spl_mmc_load_image to use a switch/case structure and easier
> > to understand spl_start_uboot checks. It also drops fallbacks on boot devices
> > that were not selected in the first place.
> 
> I don't like the dropping fallback on boot devices part and this is
> going to break existing setups.  What some people do is on platforms
> where the ROM doesn't grok FAT they still have u-boot.img on FAT and
> just keep SPL written to the raw device.  Then booting from both raw or
> RAW+FAT works.

Just sent out v2 addressing these concerns, thanks for the review!

> > Lines that go beyond 80 chars are also reduced by reducing the number of tabs.
> > Debug and error strings are refctored to match a common style.
> 
> I like the strings having a common style.  Please make sure that
> checkpatch is happy about how you re-indent the code too, thanks.

Checkpatch is happy indeed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150427/36473e4d/attachment.sig>