[U-Boot] [PATCH 05/29] fdt: arm: Drop device tree padding

Simon Glass sjg at chromium.org
Tue Apr 28 05:20:11 CEST 2015


Hi Masahiro,

On 22 April 2015 at 23:40, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> Hi Simon,
>
>
> 2015-02-28 14:06 GMT+09:00 Simon Glass <sjg at chromium.org>:
>> The 4KB padding doesn't seem necessary since we don't normally adjust the
>> control device tree file within U-Boot.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>>  arch/arm/dts/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>> index fac16cc..121725e 100644
>> --- a/arch/arm/dts/Makefile
>> +++ b/arch/arm/dts/Makefile
>> @@ -53,7 +53,7 @@ dtb-$(CONFIG_SOCFPGA) += socfpga_cyclone5_socrates.dtb
>>
>>  targets += $(dtb-y)
>>
>> -DTC_FLAGS += -R 4 -p 0x1000
>> +DTC_FLAGS += -R 4
>>
>>  PHONY += dtbs
>>  dtbs: $(addprefix $(obj)/, $(dtb-y))
>
>
> I think "-R 4" is not necessary, either.
> We do not use the reserve map for OF_CONROL.
> This option was also introduced by commit bbb0b128c,
> but its git-description does not explain the reason for its necessity.
>
> I vote for dropping "DTC_FLAGS += -R 4 -p 0x1000" line from
>
> ./arch/arm/dts/Makefile
> ./arch/powerpc/dts/Makefile
> ./arch/microblaze/dts/Makefile
> ./arch/sandbox/dts/Makefile
> ./arch/x86/dts/Makefile
> ./arch/arc/dts/Makefile

Agreed, thanks for spotting this. I'll work up a patch.

Regards,
Simon


More information about the U-Boot mailing list