[U-Boot] [PATCH V2] nand: fix buffer alignment in new verification feature

Scott Wood scottwood at freescale.com
Thu Apr 30 01:23:24 CEST 2015


On Wed, 2015-04-29 at 15:20 -0600, Stephen Warren wrote:
> On 04/14/2015 08:59 AM, Stephen Warren wrote:
> > From: Stephen Warren <swarren at nvidia.com>
> >
> > On systems with caches enabled, NAND I/O may need to flush/invalidate
> > the cache during read/write operations. For this to work correctly, all
> > buffers must be cache-aligned. Fix nand_verify*() to allocate aligned
> > buffers.
> >
> > This prevents cache alignment warnings from being spewed when using
> > U-Boot to write an updated version of itself to flash on NVIDIA Tegra
> > Seaboard (after perturbation of stack/data layout in current
> > u-boot-dm/next branch).
> >
> > I have validatd (executed) nand_verify(), but I don't think I've executed
> > nand_verify_page_oob(); testing of that would be useful.
> >
> > Cc: Peter Tyser <ptyser at xes-inc.com>
> > Cc: Heiko Schocher <hs at denx.de>
> > Cc: Scott Wood <scottwood at freescale.com>
> > Fixes: 59b5a2ad83df ("nand: Add verification functions")
> > Signed-off-by: Stephen Warren <swarren at nvidia.com>
> > ---
> > v2: Use memalign() rather than ALLOC_CACHE_ALIGN_BUFFER() so that the
> > buffer is allocated from the heap not on the stack, to reduce stack
> > usage.
> 
> Scott, does this version look good?

Yes.  I'll apply it the next time I look at U-Boot patches, or if you
want it faster:

Acked-by: Scott Wood <scottwood at freescale.com>

-Scott




More information about the U-Boot mailing list