[U-Boot] [PATCH v3 2/2] usb: eth: add Realtek RTL8152B/RTL8153 driver

Marek Vasut marex at denx.de
Tue Dec 1 18:11:22 CET 2015


On Tuesday, December 01, 2015 at 05:31:30 PM, Stephen Warren wrote:
> On 12/01/2015 08:10 AM, Marek Vasut wrote:
> > On Tuesday, December 01, 2015 at 12:24:41 PM, Ted Chen wrote:
> >> This patch adds driver support for the Realtek RTL8152B/RTL8153 USB
> >> network adapters.
> > 
> > Hi!
> > 
> > looks pretty good, just a few final nitpicks below.
> > 
> >> Signed-off-by: Ted Chen <tedchen at realtek.com>
> >> [swarren, fixed a few compiler warnings]
> >> [swarren, with permission, converted license header to SPDX]
> >> [swarren, removed printf() spew during probe()]
> > 
> > This changelog should be removed, really. It doesn't have to be in the
> > commit message, right ?
> 
> In general it's good practice when people edit someone else's patch to
> note that in the patch description so that it's obvious who to blame for
> what.
> 
> However in this particular case an exception could likely be made since
> the original patch author has taken over the patch again and made
> significantly more changes than listed above.

OK, whichever way you prefer then.

Best regards,
Marek Vasut


More information about the U-Boot mailing list