[U-Boot] [PATCH v2] axs10x: add support of generic ECHI USB 2.0 controller

[Marek Vasut]

On Tuesday, December 01, 2015 at 08:08:10 PM, Alexey Brodkin wrote:
> Hi Marek,

Hi!

> On Mon, 2015-11-30 at 19:06 +0100, Marek Vasut wrote:
> > On Monday, November 30, 2015 at 06:53:25 PM, Alexey Brodkin wrote:
> > > This commit adds support of USB 2.0 storage media on AXS10x boards.
> > > 
> > > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> > > Cc: Marek Vasut <marex at denx.de>
> > > Cc: Simon Glass <sjg at chromium.org>
> > > ---
> > 
> > Ad subject -- It's EHCI, not ECHI ;-)
> 
> Good catch!
> 
> > > diff --git a/configs/axs101_defconfig b/configs/axs101_defconfig
> > > index 52d5e2f..a541d9d 100644
> > > --- a/configs/axs101_defconfig
> > > +++ b/configs/axs101_defconfig
> > > @@ -8,6 +8,7 @@ CONFIG_DEFAULT_DEVICE_TREE="axs10x"
> > > 
> > >  CONFIG_SYS_PROMPT="AXS# "
> > >  # CONFIG_CMD_IMLS is not set
> > >  # CONFIG_CMD_FLASH is not set
> > > 
> > > +CONFIG_CMD_USB=y
> > > 
> > >  # CONFIG_CMD_SETEXPR is not set
> > >  CONFIG_CMD_DHCP=y
> > >  CONFIG_CMD_PING=y
> > > 
> > > @@ -19,4 +20,9 @@ CONFIG_CLK=y
> > > 
> > >  CONFIG_DM_ETH=y
> > >  CONFIG_ETH_DESIGNWARE=y
> > >  CONFIG_SYS_NS16550=y
> > > 
> > > +CONFIG_USB=y
> > > +CONFIG_DM_USB=y
> > > +CONFIG_USB_EHCI_HCD=y
> > 
> > You don't need EHCI_HCD in defconfig in case EHCI_GENERIC depends on it I
> > think.
> 
> Yeah but remember in drivers/usb/host it's not a dependency but conditional
> branch. That's why "savedefconfig" (but not me really) put EHCI_HCD here.

Right, got it.

Best regards,
Marek Vasut