[U-Boot] [PATCH 1/3] spl: mmc: Fix compiler warning with CONFIG_DM_MMC

Tom Rini trini at konsulko.com
Tue Dec 1 20:57:15 CET 2015


On Tue, Dec 01, 2015 at 02:02:50PM +0200, Nikita Kiryanov wrote:
> Hi Simon,
> 
> On Mon, Nov 30, 2015 at 10:19:06AM -0700, Simon Glass wrote:
> > Since commit 4188ba3 we get the following warning on rockchip boards:
> > 
> > common/spl/spl_mmc.c:111:10: error: 'mmc' undeclared (first use in this function)
> > 
> > Correct this by move the variable init earlier.
> 
> This looks suspicious. If the problem is that the variable is
> undeclared, the only way to fix it is to declare the variable, which is
> not what this patch does. I would expect this error to persist with
> the patch applied. Also, mmc is clearly declared in the function
> parameter list. It sounds to me like the source of the compile error is
> somewhere earlier in the code.

It's strange, yes.  With gcc-5.x we get an uninitalized warning which I
posted a patch for, on rockchip.  I'm not sure how on earth it would
show up as undeclared, but at least the uninitalized is just
over-zealous checking.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151201/c2bcd6a2/attachment.sig>


More information about the U-Boot mailing list