[U-Boot] [PATCH 4/6] spi: ti_qspi: compile out spi_flash_copy_mmap when DM_DMA is defined

[Simon Glass]

Hi,

On 1 December 2015 at 04:13, Mugunthan V N <mugunthanvnm at ti.com> wrote:
> When DM_DMA is defined the default spi_flash_copy_mmap() can
> handle dma memory copy, so compile out spi_flash_copy_mmap() from
> ti_qspi driver when DM_DMA config is defined.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm at ti.com>
> ---
>  drivers/spi/ti_qspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/ti_qspi.c b/drivers/spi/ti_qspi.c
> index 945290e..f6cf9f4 100644
> --- a/drivers/spi/ti_qspi.c
> +++ b/drivers/spi/ti_qspi.c
> @@ -277,7 +277,7 @@ static int __ti_qspi_xfer(struct ti_qspi_priv *priv, unsigned int bitlen,
>  }
>
>  /* TODO: control from sf layer to here through dm-spi */
> -#ifdef CONFIG_TI_EDMA3
> +#if defined(CONFIG_TI_EDMA3) && !defined(CONFIG_DM_DMA)
>  void spi_flash_copy_mmap(void *data, void *offset, size_t len)
>  {
>         unsigned int                    addr = (unsigned int) (data);
> --
> 2.6.3.368.gf34be46
>

This is also odd - shouldn't it be an option for the SPI driver,
perhaps in the device tree?

Regards,
Simon