[U-Boot] [PATCH v3 1/3] spl: mmc: Fix compiler warning with	CONFIG_DM_MMC
    Simon Glass 
    sjg at chromium.org
       
    Wed Dec  2 18:59:11 CET 2015
    
    
  
Since commit 4188ba3 we get the following warning on rockchip boards:
common/spl/spl_mmc.c:31:24: warning: ‘mmc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  count = mmc->block_dev.block_read(0, sector, 1, header);
                        ^
common/spl/spl_mmc.c:251:14: note: ‘mmc’ was declared here
  struct mmc *mmc;
Correct this by move the variable init earlier.
Signed-off-by: Simon Glass <sjg at chromium.org>
Tested-by: Michal Simek <michal.simek at xilinx.com>
---
Changes in v3:
- Move the NULL assignment to the caller
Changes in v2:
- Fix the warning in the commit message (it was the wrong one)
 common/spl/spl_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
index b3c2c64..43748d0 100644
--- a/common/spl/spl_mmc.c
+++ b/common/spl/spl_mmc.c
@@ -248,7 +248,7 @@ int spl_mmc_do_fs_boot(struct mmc *mmc)
 
 int spl_mmc_load_image(u32 boot_device)
 {
-	struct mmc *mmc;
+	struct mmc *mmc = NULL;
 	u32 boot_mode;
 	int err = 0;
 	__maybe_unused int part;
-- 
2.6.0.rc2.230.g3dd15c0
    
    
More information about the U-Boot
mailing list