[U-Boot] [PATCH 1/8] x86: fsp: Simplify fsp_continue()

Bin Meng bmeng.cn at gmail.com
Thu Dec 3 06:11:51 CET 2015


Hi Simon,

On Thu, Dec 3, 2015 at 5:05 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 2 December 2015 at 01:58, Bin Meng <bmeng.cn at gmail.com> wrote:
>> There is no need to pass shared_data to fsp_continue() so we can
>> remove unnecessary codes that simplifies the function a lot.
>
> Is this because shared_data is effectively useful for a bootloader due
> to the stack being changed?
>

The removed codes were originally from Queensbay FSP package. Looks
Intel's intention was to help stack migration, but I doubt they ever
worked. We don't support stack migration after fsp_init() hence these
codes are never needed.

>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>>  arch/x86/include/asm/fsp/fsp_support.h |  4 +---
>>  arch/x86/lib/fsp/fsp_support.c         | 29 ++++++-----------------------
>>  2 files changed, 7 insertions(+), 26 deletions(-)
>>
>
> [snip]
>
> Regards,
> Simon

Regards,
Bin


More information about the U-Boot mailing list