[U-Boot] [PATCH] iocon: Disable FIT_VERBOSE

[Tom Rini]

On Thu, Dec 03, 2015 at 09:40:46AM +0100, Dirk Eibach wrote:
> Hi Tom,
> 
> 2015-12-01 21:50 GMT+01:00 Tom Rini <trini at konsulko.com>:
> > In order to fit into image constraints again, remove this feature.
> >
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> > ---
> >  configs/iocon_defconfig |    1 +
> >  include/configs/iocon.h |    2 --
> >  2 files changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/configs/iocon_defconfig b/configs/iocon_defconfig
> > index bc5e026..a6532d1 100644
> > --- a/configs/iocon_defconfig
> > +++ b/configs/iocon_defconfig
> > @@ -1,6 +1,7 @@
> >  CONFIG_PPC=y
> >  CONFIG_4xx=y
> >  CONFIG_TARGET_IOCON=y
> > +CONFIG_FIT=y
> >  CONFIG_AUTOBOOT_KEYED=y
> >  CONFIG_AUTOBOOT_STOP_STR=" "
> >  # CONFIG_CMD_ELF is not set
> > diff --git a/include/configs/iocon.h b/include/configs/iocon.h
> > index 385a644..8663c17 100644
> > --- a/include/configs/iocon.h
> > +++ b/include/configs/iocon.h
> > @@ -35,8 +35,6 @@
> >  #undef CONFIG_ZERO_BOOTDELAY_CHECK     /* ignore keypress on bootdelay==0 */
> >
> >  /* new uImage format support */
> > -#define CONFIG_FIT
> > -#define CONFIG_FIT_VERBOSE     /* enable fit_format_{error,warning}() */
> >  #define CONFIG_FIT_DISABLE_SHA256
> >
> >  #define CONFIG_ENV_IS_IN_FLASH /* use FLASH for environment vars */
> > --
> > 1.7.9.5
> 
> NAK.
> CONFIG_FIT is an essential feature for this board.

FIT is enabled (and migrated to the config file), FIT_VERBOSE is
removed.

> It is unnerving to find our older PPC boards failing to compile
> because of size constraints after every new release. We are slowly
> running out of features to cut. Maybe we have a bloat problem here?
> I will have a look where we could squeeze out some bytes. I would hate
> to drop support for boards that are still in production :(

It's also, potentially, toolchain related.  I only saw this with I think
gcc 5.2.

> BTW is there a specific reason there was no CC to the board maintainer?

Only because I forgot, sorry!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151203/dbd46eec/attachment.sig>