[U-Boot] [PATCH v3 12/14] net: gem: Move driver to DM

Joe Hershberger joe.hershberger at gmail.com
Thu Dec 3 20:00:35 CET 2015


Hi Simon,

On Thu, Dec 3, 2015 at 12:57 PM, Simon Glass <sjg at chromium.org> wrote:
>
> On 3 December 2015 at 07:48, Michal Simek <michal.simek at xilinx.com> wrote:
> >
> > - Enable DM_ETH by default for Zynq and ZynqMP
> > - Remove board_eth_init code
> > - Change miiphy_read function to return value instead of error code
> >   based on DM requirement
> > - Do not enable EMIO DT support by default
> >
> > Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> > ---
> >
> > Changes in v3:
> > - Add remove function reported by Bin Meng
> >
> > Changes in v2:
> > - Remove accidentially added mmc code
> > - Sort dm.h header
> > - add platdata_auto_alloc_size
> > - Read iobase from pdata instead of via gev_get_addr
> > - Check positive return value from fdtdec_lookup_phandles instead of -1
> >
> >  arch/arm/Kconfig              |   2 +
> >  board/xilinx/zynq/board.c     |  13 ---
> >  board/xilinx/zynqmp/zynqmp.c  |  25 ------
> >  drivers/net/zynq_gem.c        | 179 ++++++++++++++++++++++++++----------------
> >  include/configs/zynq-common.h |   6 --
> >  include/netdev.h              |   2 -
> >  6 files changed, 112 insertions(+), 115 deletions(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> We really need to get that PHY interface moved to DM!

I made efforts in that direction months ago, but found that it is very
messy to not first move all drivers to phylib, and then from phylib to
DM. To support all 3 is just gross and unwieldy.

-Joe


More information about the U-Boot mailing list