[U-Boot] [PATCH] spl: mmc: Fix compiler warning

Marek Vasut marex at denx.de
Sat Dec 5 22:04:16 CET 2015


On Saturday, December 05, 2015 at 10:02:56 PM, Tom Rini wrote:
> On Sat, Dec 05, 2015 at 09:42:35PM +0100, Marek Vasut wrote:
> > Fix the following warning:
> > common/spl/spl_mmc.c: In function 'spl_mmc_load_image':
> > common/spl/spl_mmc.c:31:24: warning: 'mmc' may be used uninitialized in
> > this function [-Wmaybe-uninitialized]
> > 
> >   count = mmc->block_dev.block_read(0, sector, 1, header);
> >   
> >                         ^
> > 
> > common/spl/spl_mmc.c:251:14: note: 'mmc' was declared here
> > 
> >   struct mmc *mmc;
> >   
> >               ^
> > 
> > The fix is as simple as initializing the struct mmc *mmc to NULL,
> > so the subsequent functions can check if the variable is set or
> > not.
> > 
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Pantelis Antoniou <panto at antoniou-consulting.com>
> > Cc: Tom Rini <trini at konsulko.com>
> > Cc: Simon Glass <sjg at chromium.org>
> 
> I'm glad we're all grabbing gcc-5.x now.  I am however going to grab
> Simon's patch for this shortly.  Thanks!

This popped up with gcc 4.9 though ;-)
Thanks anyway.

Best regards,
Marek Vasut


More information about the U-Boot mailing list