[U-Boot] [U-Boot, v3, 3/3] spl: mmc: Unify non/driver model spl_mmc_find_device()

Tom Rini trini at konsulko.com
Sun Dec 6 23:07:52 CET 2015


On Wed, Dec 02, 2015 at 10:59:13AM -0700, Simon Glass wrote:

> It is risky to have two different functions with much the same code. Future
> authors may update one but not the other. It is hard to see which parts are
> the same and which are different.
> 
> Unify the functions and drop the differences that are not really needed.
> 
> Note that one puts() becomes printf() as Tom mentioned that this does not
> affect image size:
> 
> https://patchwork.ozlabs.org/patch/537276/
> 
> Note: It would be better to have an empty printf() and avoid the #ifdef for
> CONFIG_SPL_LIBCOMMON_SUPPORT.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Tested-by: Michal Simek <michal.simek at xilinx.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151206/13a46752/attachment.sig>


More information about the U-Boot mailing list