[U-Boot] [PATCH 6/7] mmc: mmc: Don't use sprintf when using tiny-printf

Sjoerd Simons sjoerd.simons at collabora.co.uk
Tue Dec 8 08:34:17 CET 2015


On Mon, 2015-12-07 at 17:40 -0700, Simon Glass wrote:
> On 4 December 2015 at 15:27, Sjoerd Simons
> <sjoerd.simons at collabora.co.uk> wrote:
> > There is no sprintf implementation in tiny-printf, so don't try to
> > use
> > it when tiny-printf if used.
> > 
> > Signed-off-by: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
> > ---
> > 
> >  drivers/mmc/mmc.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Acked-by: Simon Glass <sjg at chromium.org>
> Tested on firefly:
> Tested-by: Simon Glass <sjg at chromium.org>
> 
> I can't help thinking that sprintf() would not add a lot more code...

Probably not (it's write to buffer rather then write to output, so
maybe just passing a function pointer for an out function in would just
do the job). More work then I had time for though :/

Though i'm not sure it's worth it though (at least on firefly the spl
won't output those fields) :)

-- 
Sjoerd Simons
Collabora Ltd.


More information about the U-Boot mailing list