[U-Boot] [PATCH 4/5] board: atmel: clean up peripheral clock code
Yang, Wenyou
Wenyou.Yang at atmel.com
Wed Dec 9 08:55:00 CET 2015
Hello Heiko,
Thank you for your review.
> -----Original Message-----
> From: Heiko Schocher [mailto:hs at denx.de]
> Sent: 2015年12月9日 14:56
> To: Yang, Wenyou <Wenyou.Yang at atmel.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>
> Subject: Re: [U-Boot] [PATCH 4/5] board: atmel: clean up peripheral clock code
>
> Hello Wenyou,
>
> Am 09.12.2015 um 04:45 schrieb Wenyou Yang:
> > Due to introducing the new peripheral clock handle functions, use
> > these functions to reduce duplicated code.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>
> > ---
> >
> > board/atmel/at91rm9200ek/at91rm9200ek.c | 1 -
> > board/atmel/at91rm9200ek/led.c | 5 +----
> > board/atmel/at91sam9260ek/at91sam9260ek.c | 15 +++++----------
> > board/atmel/at91sam9261ek/at91sam9261ek.c | 8 ++------
> > board/atmel/at91sam9261ek/led.c | 6 ++----
> > board/atmel/at91sam9263ek/at91sam9263ek.c | 23 +++++++----------------
> > board/atmel/at91sam9263ek/led.c | 9 +++------
> > board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c | 20 +++++-------------
> --
> > board/atmel/at91sam9m10g45ek/led.c | 7 ++-----
> > board/atmel/at91sam9n12ek/at91sam9n12ek.c | 6 ++----
> > board/atmel/at91sam9rlek/at91sam9rlek.c | 18 ++++++------------
> > board/atmel/at91sam9rlek/led.c | 7 ++-----
> > board/atmel/at91sam9x5ek/at91sam9x5ek.c | 10 +++-------
> > board/atmel/sama5d2_xplained/sama5d2_xplained.c | 1 -
> > board/atmel/sama5d3_xplained/sama5d3_xplained.c | 5 ++---
> > board/atmel/sama5d3xek/sama5d3xek.c | 5 ++---
> > board/atmel/sama5d4_xplained/sama5d4_xplained.c | 5 ++---
> > board/atmel/sama5d4ek/sama5d4ek.c | 5 ++---
> > board/bluewater/snapper9260/snapper9260.c | 15 +++++----------
> > board/calao/usb_a9263/usb_a9263.c | 11 ++++-------
> > board/egnite/ethernut5/ethernut5.c | 20 ++++++++------------
> > board/esd/meesc/meesc.c | 15 ++++++---------
> > board/mini-box/picosam9g45/led.c | 7 ++-----
> > board/mini-box/picosam9g45/picosam9g45.c | 17 ++++-------------
> > board/ronetix/pm9261/led.c | 7 ++-----
> > board/ronetix/pm9261/pm9261.c | 22 ++++++----------------
> > board/ronetix/pm9263/led.c | 7 ++-----
> > board/ronetix/pm9263/pm9263.c | 19 +++++--------------
> > board/ronetix/pm9g45/pm9g45.c | 20 ++++++--------------
> > board/siemens/corvus/board.c | 6 ++----
> > board/siemens/smartweb/smartweb.c | 3 +--
> > board/siemens/taurus/taurus.c | 3 +--
> > 32 files changed, 102 insertions(+), 226 deletions(-)
>
> Sorry this patch has checkpatcherrors:
>
> 2015-12-09 07:49:38,661: hs at pollux [ 7:49:38] ttbott >
> 2015-12-09 07:49:39,790: wget http://patchwork.ozlabs.org/patch/554219/mbox
> 2015-12-09 07:49:39,791: --2015-12-09 07:49:39--
> http://patchwork.ozlabs.org/patch/554219/mbox
> 2015-12-09 07:49:39,791: Resolving patchwork.ozlabs.org
> (patchwork.ozlabs.org)... 103.22.144.67,
> 2401:3900:2:1::2
> 2015-12-09 07:49:40,106: Connecting to patchwork.ozlabs.org
> (patchwork.ozlabs.org)|103.22.144.67|:80... connected.
> 2015-12-09 07:49:40,420: HTTP request sent, awaiting response... 301 MOVED
> PERMANENTLY
> 2015-12-09 07:49:40,421: Location:
> http://patchwork.ozlabs.org/patch/554219/mbox/ [following]
> 2015-12-09 07:49:40,421: --2015-12-09 07:49:40--
> http://patchwork.ozlabs.org/patch/554219/mbox/
> 2015-12-09 07:49:40,421: Reusing existing connection to
> patchwork.ozlabs.org:80.
> 2015-12-09 07:49:40,786: HTTP request sent, awaiting response... 200 OK
> 2015-12-09 07:49:40,786: Length: unspecified [text/plain]
> 2015-12-09 07:49:40,786: Saving to: ‘mbox’
> 2015-12-09 07:49:40,786:
> 2015-12-09 07:49:40,787:
> 2015-12-09 07:49:41,101: mbox [<=> ] 0 --.-KB/s
> 2015-12-09 07:49:41,133: mbox [ <=> ] 15.15K 45.0KB/s
> 2015-12-09 07:49:41,134: mbox [ <=> ] 41.60K 111KB/s
> in 0.4s
> 2015-12-09 07:49:41,134:
> 2015-12-09 07:49:41,134: 2015-12-09 07:49:41 (111 KB/s) - ‘mbox’ saved [42603]
> 2015-12-09 07:49:41,134:
> 2015-12-09 07:49:41,134: hs at pollux [ 7:49:41] ttbott >
> 2015-12-09 07:49:42,235: if [ $? -ne 0 ]; then echo 'FAILED'; fi
> 2015-12-09 07:49:42,235: hs at pollux [ 7:49:42] ttbott >
> 2015-12-09 07:49:43,333: scripts/checkpatch.pl mbox
> 2015-12-09 07:49:43,698: WARNING: line over 80 characters
> 2015-12-09 07:49:43,698: #1029: FILE: board/ronetix/pm9261/pm9261.c:167:
> 2015-12-09 07:49:43,699: + at91_system_clk_enable(AT91_PMC_HCK1); /*
> LCD controller Clock,
> AT91SAM9261 only */
> 2015-12-09 07:49:43,699:
> 2015-12-09 07:49:43,699: total: 0 errors, 1 warnings, 0 checks, 1000 lines
> checked
> 2015-12-09 07:49:43,699:
> 2015-12-09 07:49:43,699: NOTE: Ignored message types: COMPLEX_MACRO
> CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
> NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE
> 2015-12-09 07:49:43,700:
> 2015-12-09 07:49:43,700: mbox has style problems, please review.
> 2015-12-09 07:49:43,700:
> 2015-12-09 07:49:43,700: If any of these errors are false positives, please report
> 2015-12-09 07:49:43,700: them to the maintainer, see CHECKPATCH in
> MAINTAINERS.
> 2015-12-09 07:49:43,701: hs at pollux [ 7:49:43] ttbott >
Fix it in the next version. Thanks
>
> bye,
> Heiko
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Best Regards,
Wenyou Yang
More information about the U-Boot
mailing list