[U-Boot] [PATCH v8 14/14] sf: Rename sf_ops.c to spi-flash.c

Bin Meng bmeng.cn at gmail.com
Thu Dec 10 02:31:44 CET 2015


On Wed, Dec 9, 2015 at 12:54 PM, Simon Glass <sjg at chromium.org> wrote:
> On 6 December 2015 at 11:34, Jagan Teki <jteki at openedev.com> wrote:
>> Since all spi-flash core operations are moved into
>> sf_ops.c then it's better to renamed as spi-flash.c
>>
>> Signed-off-by: Jagan Teki <jteki at openedev.com>
>> ---
>>  drivers/mtd/spi/Makefile                  | 2 +-
>>  drivers/mtd/spi/{sf_ops.c => spi-flash.c} | 7 ++++---
>>  2 files changed, 5 insertions(+), 4 deletions(-)
>>  rename drivers/mtd/spi/{sf_ops.c => spi-flash.c} (99%)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> (but I suggest spi_flash.c is better as it fits with the other files)

Agreed. spi_flash.c makes more sense. So far it looks that only driver
model uclass driver is using - in the file name, others are using _.

Other than this,

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list