[U-Boot] [PATCH] Revert "spi: fsl_qspi: Use GENMASK"

[Fabio Estevam]

Hi Troy,

On Thu, Dec 10, 2015 at 7:10 PM, Troy Kisky
<troy.kisky at boundarydevices.com> wrote:
> If GENMASK is REALLY desired, it should be GENMASK(23,0)
> But since GENMASK is obviously more confusing, let's just revert
>
> This reverts commit bad490a24212c068c5b718b9189f47ea4075d078.

You missed your Signed-off-by.

>
> diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c
> index 169835e..0a161b6 100644
> --- a/drivers/spi/fsl_qspi.c
> +++ b/drivers/spi/fsl_qspi.c
> @@ -25,7 +25,7 @@ DECLARE_GLOBAL_DATA_PTR;
>  #define TX_BUFFER_SIZE         0x40
>  #endif
>
> -#define OFFSET_BITS_MASK       GENMASK(24, 0)
> +#define OFFSET_BITS_MASK       0x00ffffff

Yes, much better with the old and original mask.

When you send a v2 you can add:

Reviewed-by: Fabio Estevam <fabio.estevam at freescale.com>