[U-Boot] [PATCH 1/2] ns16550: update compatible and reg-shift binding

Thomas Chou thomas at wytron.com.tw
Fri Dec 11 08:08:47 CET 2015


Hi Stephen,

On 2015年12月11日 13:35, Stephen Warren wrote:
> On 12/10/2015 10:08 PM, Thomas Chou wrote:
>> Update compatible and reg-shift in device tree binding.
>
> Has this change been submitted to and accepted by the Linux kernel?
> That's where the official DT binding documents are stored. Honestly I
> think we should remove the copies in U-Boot to avoid confusion and forking.
>
> The content of the change looks reasonable at a quick glance.
>

These changes actually came from Linux kernel. They are scattered in 
several files. I included only those are prevalent to u-boot.

8250.txt
- compatible : one of:
	- "ns8250"
	- "ns16450"
	- "ns16550a"
	- "ns16550"
	- "ns16750"
	- "ns16850"
	- For Tegra20, must contain "nvidia,tegra20-uart"
	- For other Tegra, must contain '"nvidia,<chip>-uart",
	  "nvidia,tegra20-uart"' where <chip> is tegra30, tegra114, tegra124,
	  tegra132, or tegra210.

omap_serial.txt
- compatible : should be "ti,omap2-uart" for OMAP2 controllers
- compatible : should be "ti,omap3-uart" for OMAP3 controllers
- compatible : should be "ti,omap4-uart" for OMAP4 controllers
- compatible : should be "ti,am4372-uart" for AM437x controllers
- compatible : should be "ti,am3352-uart" for AM335x controllers
- compatible : should be "ti,dra742-uart" for DRA7x controllers

snps-dw-apb-uart.txt
- compatible : "snps,dw-apb-uart"
- reg-shift : quantity to shift the register offsets by.  If this 
property is not present then the register offsets are not shifted.

I can change the description reg-shift property to above if this make it 
clearer.

I would agree that we can remove these copies of Linux kernel. Almost 
every dts binding I added to u-boot these months are copied from Linux 
kernel.

Best regards,
Thomas


More information about the U-Boot mailing list