[U-Boot] [PATCH 1/6] arm: socfpga: cyclone5-socdk: Enabling mtd partitioning layout

[Chin Liang See]

On Fri, 2015-12-11 at 15:21 +0100, Marek Vasut wrote:
> On Friday, December 11, 2015 at 10:15:48 AM, Chin Liang See wrote:
> > Enabling mtd partitioning layout which indicate partition
> > for various boot partition
> > 
> > Signed-off-by: Chin Liang See <clsee at altera.com>
> > Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux at gmail.com>
> > Cc: Pavel Machek <pavel at denx.de>
> > Cc: Marek Vasut <marex at denx.de>
> > Cc: Stefan Roese <sr at denx.de>
> > ---
> >  include/configs/socfpga_cyclone5_socdk.h | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/include/configs/socfpga_cyclone5_socdk.h
> > b/include/configs/socfpga_cyclone5_socdk.h index 67bb35f..e4a1657
> > 100644
> > --- a/include/configs/socfpga_cyclone5_socdk.h
> > +++ b/include/configs/socfpga_cyclone5_socdk.h
> > @@ -96,4 +96,16 @@
> >  /* The rest of the configuration is shared */
> >  #include <configs/socfpga_common.h>
> > 
> > +/* mtd partitioning for serial NOR flash */
> > +#if defined(CONFIG_CMD_UBI) || defined(CONFIG_CMD_SF)
> 
> Is this the default Altera layout ?

Yah but believe it need to be updated 

> 
> > +#define MTDPARTS_DEFAULT	"mtdparts=ff705000.spi:"\
> > +				"256k(spl),"		\
> > +				"64k(env),"		\
> > +				"64k(dtb),"		\
> 
> What happens if the DT grows over 64k ?

Hmmm rethinking of this, I will make Linux dtb, U-Boot and kernel as
part of one big UBI partition called boot.

> 
> > +				"256k(boot),"		\
> 
> 256k is not enough for U-Boot (considering this is U-Boot).

Will create boot region to avoid worrying the size issue

> > +				"16m(kernel),"		\
> > +				"16m(rootfs),"		\
> 
> Why don't you put kernel and rootfs onto the UBI volume instead ?

Yup, kernel will go into boot partition. It will be separated from
rootfs as user might choose nfs.

Thanks
Chin Liang

> 
> > +				"-(UBI)\0"
> > +#endif
> > +
> >  #endif	/* __CONFIG_SOCFPGA_CYCLONE5_H__ */
> > --
> > 1.9.2.468.g3f0c02a
> 
> Best regards,
> Marek Vasut