[U-Boot] [PATCH 1/2] spl: dm: Add SPL_DM_SEQ_ALIAS config option

Nathan Rossi nathan at nathanrossi.com
Sat Dec 12 15:08:21 CET 2015


On Sat, Dec 12, 2015 at 10:05 PM, Stefan Roese <sr at denx.de> wrote:
> On 11.12.2015 18:32, Marek Vasut wrote:
>>
>> On Friday, December 11, 2015 at 04:46:40 PM, Michal Simek wrote:
>>>
>>> On 11.12.2015 16:07, Marek Vasut wrote:
>>>>
>>>> On Friday, December 11, 2015 at 03:48:09 PM, Nathan Rossi wrote:
>>>>>
>>>>> The Device Model sequence alias feature is required by some Uclasses.
>>>>> Instead of disabling the feature for all SPL targets allow it to be
>>>>> configured.
>>>>>
>>>>> The config option is disabled by default to reduce code size for
>>>>> targets
>>>>> that are not interested or do not require this feature.
>>>>>
>>>>> Signed-off-by: Nathan Rossi <nathan at nathanrossi.com>
>>>>> Cc: Simon Glass <sjg at chromium.org>
>>>>> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
>>>>> Cc: Linus Walleij <linus.walleij at linaro.org>
>>>>> Cc: Marek Vasut <marex at denx.de>
>>>>> Cc: Michal Simek <michal.simek at xilinx.com>
>>>>> ---
>>>>> Based on a small amount of inspection for the Zynq platform, enabling
>>>>> this config option adds ~1KB of code size.
>>>>>
>>>>> Also on a side note, this might affect the socfpga target as it
>>>>> forcibly
>>>>> overrides the #undef from config_uncmd_spl.h in its common header. I
>>>>> have Cc'd the respective maintainer for this reason.
>>>>
>>>>
>>>> The fix for SoCFPGA is easy -- enable the SPL_DM_SEQ_ALIAS in
>>>> configs/socfpga*. It is needed for booting from QSPI NOR.

I will add a patch to this series, depending on how it is agreed to
enable this option.

>>>
>>>
>>> That's probably not the best solution. But of course we can use it.
>>> IRC Stefan had the same problem.

So would a better solution be to force the ARCH_ZYNQ config (and
others ARCH_SOCFPGA/ARCH_MVEBU) to 'select SPL_DM_SEQ_ALIAS' instead
of enabling them separately for each defconfig? like is done for
SPL_OF_CONTROL/etc.

>>
>>
>> So what is the solution ?
>
>
> I added
>
> #define CONFIG_DM_SEQ_ALIAS            1
>
> to the common config header for MVEBU. If its possible to set this
> via Kconfig in a way where its not #undef'ed by config_uncmd_spl.h,
> that would be even better.

As with socfpga, would you like me to do the same for MVEBU, add a
patch to this series to enable it for MVEBU?

Regards,
Nathan


More information about the U-Boot mailing list