[U-Boot] [PATCH] powerpc: mpc85xx: Move set_liodns, setup_portals to common boot seq

York Sun yorksun at freescale.com
Tue Dec 15 03:57:12 CET 2015



On 11/06/2015 04:44 PM, Prabhakar Kushwaha wrote:
> Users migrating Freescale's PowerPC SoC U-Boot code to their custom
> board, often overlook the need to execute set_liodns() and
> setup_portals() being called by platform files.
> 
> So Move set_liodns() and setup_portals() to common u-boot boot
> sequence
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar at freescale.com>
> ---
>  arch/powerpc/cpu/mpc85xx/cpu_init.c     | 7 +++++++
>  board/freescale/b4860qds/b4860qds.c     | 5 -----
>  board/freescale/corenet_ds/corenet_ds.c | 6 ------
>  board/freescale/p2041rdb/p2041rdb.c     | 3 ---
>  board/freescale/t102xqds/t102xqds.c     | 5 -----
>  board/freescale/t102xrdb/t102xrdb.c     | 5 -----
>  board/freescale/t1040qds/t1040qds.c     | 5 -----
>  board/freescale/t104xrdb/t104xrdb.c     | 6 ------
>  board/freescale/t208xqds/t208xqds.c     | 6 ------
>  board/freescale/t208xrdb/t208xrdb.c     | 6 ------
>  board/freescale/t4qds/t4240emu.c        | 6 ------
>  board/freescale/t4qds/t4240qds.c        | 6 ------
>  board/freescale/t4rdb/t4240rdb.c        | 6 ------
>  13 files changed, 7 insertions(+), 65 deletions(-)

Prabhakar,

This change is not good. You presume set_liodns() is available for all 85xx.
Putting the call into cpu_init.c caused compiling error for non-corenet SoCs.

Please update and make sure you run buildman on powerpc.

York



More information about the U-Boot mailing list