[U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()

Bin Meng bmeng.cn at gmail.com
Tue Dec 15 05:20:58 CET 2015


Hi Michal,

On Mon, Dec 14, 2015 at 11:53 PM, Michal Simek <michal.simek at xilinx.com> wrote:
> Reported-by: Thomas Chou <thomas at wytron.com.tw>
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---

Could you always include a simple sentence in the commit message?

>
>  drivers/serial/serial_xuartlite.c | 2 +-
>  drivers/serial/serial_zynq.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
> index fe87b515d902..0238a52380c7 100644
> --- a/drivers/serial/serial_xuartlite.c
> +++ b/drivers/serial/serial_xuartlite.c
> @@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = {
>  };
>
>  #ifdef CONFIG_DEBUG_UART_UARTLITE
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
>  {
>         struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE;
>
> diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c
> index b2b98dea1561..3430482f8d8b 100644
> --- a/drivers/serial/serial_zynq.c
> +++ b/drivers/serial/serial_zynq.c
> @@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = {
>  };
>
>  #ifdef CONFIG_DEBUG_UART_ZYNQ
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
>  {
>         struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
>
> --

Other than that,

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Regards,
Bin


More information about the U-Boot mailing list