[U-Boot] [PATCH 2/5] net: gem: Fix return value from recv

Michal Simek michal.simek at xilinx.com
Wed Dec 16 09:05:43 CET 2015


Hi Joe,

On 15.12.2015 20:51, Joe Hershberger wrote:
> Hi Michal,
> 
> On Tue, Dec 15, 2015 at 11:47 AM, Joe Hershberger
> <joe.hershberger at gmail.com> wrote:
>> On Fri, Dec 11, 2015 at 5:43 AM, Michal Simek <michal.simek at xilinx.com> wrote:
>>> recv function should return 0 instead of frame_len not to
>>> proceed the same packet again in core.
>>>
>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>
>> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
> 
> Oops. NAK. Didn't realize this was the top-level recv function being
> passed to the eth layer.

I expect that origin ACK was valid and you realized like for other
driver that here should be return 0 because separation with free_pkt is
done in 3/5.

Thanks,
Michal


More information about the U-Boot mailing list