[U-Boot] [PATCH 3/6] usb: dwc2: determine TT hub address and port for split transactions

Stefan Bruens stefan.bruens at rwth-aachen.de
Thu Dec 17 04:16:28 CET 2015


On Tuesday 15 December 2015 20:17:32 Stephen Warren wrote:
> On 12/12/2015 09:17 PM, Stefan Brüns wrote:
> > Start split and complete split tokens need the hub address and the
> > downstream port of the first HS hub (device view).
> > Code copied from host/ehci_hcd.c
> 
> Rather than cut/paste this, shouldn't you create a common function that
> can be shared between all users?

Good idea, as the code is also duplicated in musb-new.

Any suggestions where to put the new function? For CONFIG_DM_USB there is 
usb_uclass.c. Move it into usb_uclass.c and leave the non DM variants in place 
(same name, but declared static)?

Kind regards,

Stefan

-- 
Stefan Brüns  /  Bergstraße 21  /  52062 Aachen
home: +49 241 53809034     mobile: +49 151 50412019
work: +49 2405 49936-424


More information about the U-Boot mailing list