[U-Boot] [PATCH] arm: socfpga: Fixed Phy not found error. Fixed QSPI flash not found error Disabled Hardware watch dog by default. Updated MMC clock.

Marek Vasut marex at denx.de
Thu Dec 17 04:46:55 CET 2015


On Thursday, December 17, 2015 at 04:25:28 AM, ShengjiangWu wrote:
> arm: socfpga: Fixed Phy not found error.
>                   Fixed QSPI flash not found error
>                   Disabled Hardware watch dog by default.
>                   Updated MMC clock.

Fix your mailer please.

>     Updated pinmux and clock for EMAC1 and QSPI flash.
>     U-BOOT-2015-10 can run on Cyclone V SoC Development
>     Kit (SoCDK) with this fix.
> 
>     Signed-off-by: swu <shengjiangwu at gmail.com>
>     Cc: Chin Liang See <clsee at altera.com>
>     Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
>     Cc: Dinh Nguyen <dinh.linux at gmail.com>
>     Cc: Pavel Machek <pavel at denx.de>
>     Cc: Marek Vasut <marex at denx.de>
>     Cc: Stefan Roese <sr at denx.de>

Please repost the patch using git send-email , details are at [1] and the 
process is very similar to Linux.

I briefly skimmed across the patch. I don't understand why do you replace
almost the entire pinmux just to fix ethernet issue. (ethernet works on
SoCDK I believe, which is another odd thing).

Furthermore, if you're fixing multiple things, split them into multiple
patches.

Finally, do not disable HW watchdog.

[1] www.denx.de/wiki/U-Boot/Patches

Best regards,
Marek Vasut


More information about the U-Boot mailing list