[U-Boot] [PATCH] mips: add base support for atheros ar71xx based SOCs

[Wills Wang]

Hi, Antony,

I'm sorry, i can't find any code for cache operation in lowlevel_init 
routine.
I mean there are no code maintenance cache in this patch , such as 
"cache reset" and "dcache enable".

Best Regards
Wills

On 12/19/2015 12:16 AM, Antony Pavlov wrote:
> On Fri, 18 Dec 2015 23:24:22 +0800
> Wills Wang <wills.wang at live.com> wrote:
>
>> On 12/18/2015 08:54 PM, Antony Pavlov wrote:
>>> On Fri, 18 Dec 2015 15:34:29 +0800
>>> Wills Wang <wills.wang at live.com> wrote:
>>>
>>>> This patch enable work for ar933x SOC, tested on ar9331
>>>>
>>>> Signed-off-by: Wills Wang <wills.wang at live.com>
>>>> ---
>>>>
>>>>    arch/mips/Makefile                          |    1 +
>>>>    arch/mips/include/asm/ar71xx.h              | 1144 +++++++++++++++++++++++++++
>>>>    arch/mips/mach-ath79/Makefile               |    8 +
>>>>    arch/mips/mach-ath79/ar933x/Makefile        |   11 +
>>>>    arch/mips/mach-ath79/ar933x/dram.c          |   27 +
>>>>    arch/mips/mach-ath79/ar933x/lowlevel_init.S |  784 ++++++++++++++++++
>>>>    arch/mips/mach-ath79/ar933x/reset.c         |   29 +
>>>>    arch/mips/mach-ath79/ar933x/serial.c        |  348 ++++++++
>>>>    arch/mips/mach-ath79/config.mk              |    8 +
>>>>    9 files changed, 2360 insertions(+)
>>>>    create mode 100644 arch/mips/include/asm/ar71xx.h
>>>>    create mode 100644 arch/mips/mach-ath79/Makefile
>>>>    create mode 100644 arch/mips/mach-ath79/ar933x/Makefile
>>>>    create mode 100644 arch/mips/mach-ath79/ar933x/dram.c
>>>>    create mode 100644 arch/mips/mach-ath79/ar933x/lowlevel_init.S
>>>>    create mode 100644 arch/mips/mach-ath79/ar933x/reset.c
>>>>    create mode 100644 arch/mips/mach-ath79/ar933x/serial.c
>>>>    create mode 100644 arch/mips/mach-ath79/config.mk
>>> 1. Your lowlevel_init routine duplicates cache maintenance functions by Paul Burton
>>> (please see commit 4a5d8898bca3e442b6 'MIPS: unify cache initialization code').
>> Can you tell me which lines involve the cache maintenance function?
>
> Please see mips_cache_reset and dcache_enable functions
> in the commit 4a5d8898bca3e442b6 'MIPS: unify cache initialization code'.
>
>
>>> 2. Can we select build for ar71xx from .config? I suppose 'No',
>>> because the patch does not add any Kconfig option.
>> Yes,  this patch refer to the au1x00 machine, we can select which target
>> was build.
>>> 3. Can we put your arch/mips/mach-ath79/ar933x/serial.c into drivers/serial?
>> Ok.
>>> 4. The patch is suffering from very very many unused macros in ar71xx.h.
>> File "ar71xx.h" copy from mainline kernel, the future patch should use
>> other macros.
>>> 5. The patch has whitespace errors, please see this git-am log:
>>>
>>>       Applying: mips: add base support for atheros ar71xx based SOCs
>>>       .git/rebase-apply/patch:1180: new blank line at EOF.
>>>       +
>>>       .git/rebase-apply/patch:2069: new blank line at EOF.
>>>       +
>>>       warning: 2 lines add whitespace errors.
>> Ok, thanks!
>>> -- 
>>> Best regards,
>>>     Antony Pavlov
>>>
>>>
>> Best Regards
>> Wills
>