[U-Boot] [PATCH 00/11] zap: Do not use macros that are equivalent to IS_ENABLED(CONFIG_...)
Simon Glass
sjg at chromium.org
Fri Dec 18 19:57:18 CET 2015
Hi Masahiro,
On 17 December 2015 at 20:23, Marek Vasut <marex at denx.de> wrote:
> On Friday, December 18, 2015 at 03:04:59 AM, Masahiro Yamada wrote:
>> Please stop such coding habit as follows:
>>
>> #ifdef CONFIG_FOO
>> # define ENABLE_FOO 1
>> #else
>> # define ENABLE_FOO 0
>> #endif
>
> Oh yes, this is horrible, kill this with fire :)
>
>> Use IS_ENABLED(CONFIG_FOO), instead.
>>
>>
>>
>> Masahiro Yamada (11):
>> image: zap IMAGE_ENABLE_RAMDISK_HIGH
>> image: zap IMAGE_ENABLE_OF_LIBFDT
>> image: zap IMAGE_BOOT_GET_CMDLINE
>> image: zap IMAGE_OF_BOARD_SETUP
>> image: zap IMAGE_OF_SYSTEM_SETUP
>> ARM: bootm: BOOTM_ENABLE_SERIAL_TAG
>> ARM: bootm: BOOTM_ENABLE_CMDLINE_TAG
>> ARM: bootm: BOOTM_ENABLE_REVISION_TAG
>> ARM: bootm: BOOTM_ENABLE_MEMORY_TAG
>> ARM: bootm: BOOTM_ENABLE_INITRD_TAG
>> ARM: bootm: drop redundant #ifdef conditional
>>
>> arch/arc/lib/bootm.c | 2 +-
>> arch/arm/include/asm/bootm.h | 22 ----------------------
>> arch/arm/lib/bootm.c | 16 +++++++---------
>> common/image-fdt.c | 6 +++---
>> common/image.c | 10 +++++-----
>> include/image.h | 30 ------------------------------
>> 6 files changed, 16 insertions(+), 70 deletions(-)
I definitely agree it would be good to drop this. But does it work? I
thought IS_ENABLED() only worked for Kconfig options?
Regards,
Simon
More information about the U-Boot
mailing list