[U-Boot] u-boot 2016.01-rc2 detects BeagleBone Black incorrectly

[Matwey V. Kornilov]

2015-12-17 21:08 GMT+03:00 Robert Nelson <robertcnelson at gmail.com>:
> On Thu, Dec 17, 2015 at 11:54 AM, Matwey V. Kornilov
> <matwey.kornilov at gmail.com> wrote:
>> 2015-12-17 3:53 GMT+03:00 Robert Nelson <robertcnelson at gmail.com>:
>>> Hi Matwey
>>>
>>> On Sat, Dec 12, 2015 at 3:14 AM, Matwey V. Kornilov
>>> <matwey.kornilov at gmail.com> wrote:
>>>> Hello,
>>>>
>>>> I am running 2016.01-rc on BBB (Embest replica)
>>>>
>>>> printenv shows the following:
>>>>
>>>> findfdt=if test $board_name = A335BONE; then setenv fdtfile
>>>> am335x-bone.dtb; fi; if test $board_name = A335BNLT; then if test
>>>> $board_rev = BBG1; then setenv fdtfile am335x-bonegreen.dtb; else setenv
>>>> fdtfile am335x-boneblack.dtb; fi; fi; if test $board_name = A33515BB;
>>>> then setenv fdtfile am335x-evm.dtb; fi; if test $board_name = A335X_SK;
>>>> then setenv fdtfile am335x-evmsk.dtb; fi; if test $fdtfile = undefined;
>>>> then echo WARNING: Could not determine device tree to use; fi;
>>>>
>>>> after findfdt has been run,
>>>>
>>>> fdtfile=am335x-bonegreen.dtb
>>>>
>>>> But it is not correct. My $board_rev is the following, I have no idea
>>>> why does it contain line break.
>>>>
>>>> board_name=A335BNLT
>>>> board_rev=t\
>>>
>>> Yuck, another variation!  Can you do me a favor and dump the eeprom:
>>>
>>> https://github.com/beagleboard/image-builder/blob/master/readme.md
>>>
>>> Download and run:
>>>
>>> wget https://raw.githubusercontent.com/RobertCNelson/boot-scripts/master/device/bone/tester/show-eeprom.sh
>>>
>>> sudo /bin/bash show-eeprom.sh
>>
>> # sudo /bin/bash show-eeprom.sh
>> eeprom: [�U3�A335BNLTt
>> ue]
>> eeprom raw: [00000000  aa 55 33 ee 41 33 33 35  42 4e 4c 54 74 0a 75
>> 65  |.U3.A335BNLTt.ue|]
>
> ah, it's tripping on the "." = "0a" character..
>
> Do you happen to remember where you purchased it and what it was
> called.. (for git commit)
>
> This patch should work:
>
> https://gist.github.com/RobertCNelson/21f44591c78daed7c637
>

The patch works good.
But could you please explain me? I thought the problem was in 'test' operator.
Unlikely
test '\0x74\0x0a\0x75\0x65' = BBG1
should be true.

> Please test,
>
> and i've added it to our table:
>
> https://github.com/RobertCNelson/omap-image-builder/commit/620ebf627d3df8c693845bef07af232aa289ff41
>
> Regards,
>
> --
> Robert Nelson
> https://rcn-ee.com/



-- 
With best regards,
Matwey V. Kornilov
http://blog.matwey.name
xmpp://0x2207@jabber.ru