[U-Boot] [PATCH V2 4/7] test/py: test the md/mw commands

[Simon Glass]

Hi Stephen,

On 2 December 2015 at 15:18, Stephen Warren <swarren at wwwdotorg.org> wrote:
> This tests whether md/mw work, and affect each-other.
>
> Command repeat is also tested.
>
> test/cmd_repeat.sh is removed, since the new Python-based test does
> everything it used to.
>
> Signed-off-by: Stephen Warren <swarren at wwwdotorg.org>
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
>  test/cmd_repeat.sh | 29 -----------------------------
>  test/py/test_md.py | 29 +++++++++++++++++++++++++++++
>  2 files changed, 29 insertions(+), 29 deletions(-)
>  delete mode 100755 test/cmd_repeat.sh
>  create mode 100644 test/py/test_md.py

Reviewed-by: Simon Glass <sjg at chromium.org>

But please add a little comment on each test function.

>
> diff --git a/test/cmd_repeat.sh b/test/cmd_repeat.sh
> deleted file mode 100755
> index 990e79900f47..000000000000
> --- a/test/cmd_repeat.sh
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -#!/bin/sh
> -
> -# Test for U-Boot cli including command repeat
> -
> -BASE="$(dirname $0)"
> -. $BASE/common.sh
> -
> -run_test() {
> -       ./${OUTPUT_DIR}/u-boot <<END
> -setenv ctrlc_ignore y
> -md 0
> -
> -reset
> -END
> -}
> -check_results() {
> -       echo "Check results"
> -
> -       grep -q 00000100 ${tmp} || fail "Command did not repeat"
> -}
> -
> -echo "Test CLI repeat"
> -echo
> -tmp="$(tempfile)"
> -build_uboot
> -run_test >${tmp}
> -check_results ${tmp}
> -rm ${tmp}
> -echo "Test passed"
> diff --git a/test/py/test_md.py b/test/py/test_md.py
> new file mode 100644
> index 000000000000..2e67ed0a1de2
> --- /dev/null
> +++ b/test/py/test_md.py
> @@ -0,0 +1,29 @@
> +# Copyright (c) 2015 Stephen Warren
> +# Copyright (c) 2015, NVIDIA CORPORATION. All rights reserved.
> +#
> +# SPDX-License-Identifier: GPL-2.0
> +
> +import pytest
> +
> + at pytest.mark.buildconfigspec("cmd_memory")
> +def test_md(uboot_console):
> +    ram_base = uboot_console.find_ram_base()
> +    addr = "%08x" % ram_base
> +    val = "a5f09876"
> +    expected_response = addr + ": " + val
> +    response = uboot_console.run_command("md " + addr + " 10")
> +    assert(not (expected_response in response))
> +    uboot_console.run_command("mw " + addr + " " + val)
> +    response = uboot_console.run_command("md " + addr + " 10")
> +    assert(expected_response in response)
> +
> + at pytest.mark.buildconfigspec("cmd_memory")
> +def test_md_repeat(uboot_console):
> +    ram_base = uboot_console.find_ram_base()
> +    addr_base = "%08x" % ram_base
> +    words = 0x10
> +    addr_repeat = "%08x" % (ram_base + (words * 4))
> +    uboot_console.run_command("md %s %x" % (addr_base, words))
> +    response = uboot_console.run_command("")
> +    expected_response = addr_repeat + ": "
> +    assert(expected_response in response)
> --
> 2.6.3
>

Regards,
Simon