[U-Boot] [PATCH 10/10] x86: Add Intel Cougar Canyon 2 board

Bin Meng bmeng.cn at gmail.com
Mon Dec 21 03:34:21 CET 2015


Hi Simon,

On Sat, Dec 19, 2015 at 10:52 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 11 December 2015 at 03:55, Bin Meng <bmeng.cn at gmail.com> wrote:
>> This adds basic support to Intel Cougar Canyon 2 board, a board
>> based on Chief River platform with an Ivy Bridge processor and
>> a Panther Point chipset.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>
>> ---
>>
>>  arch/x86/dts/Makefile                     |  1 +
>>  arch/x86/dts/cougarcanyon2.dts            | 96 +++++++++++++++++++++++++++++++
>>  board/intel/Kconfig                       |  9 +++
>>  board/intel/cougarcanyon2/Kconfig         | 25 ++++++++
>>  board/intel/cougarcanyon2/MAINTAINERS     |  6 ++
>>  board/intel/cougarcanyon2/Makefile        |  7 +++
>>  board/intel/cougarcanyon2/cougarcanyon2.c | 48 ++++++++++++++++
>>  board/intel/cougarcanyon2/start.S         |  9 +++
>>  configs/cougarcanyon2_defconfig           | 21 +++++++
>>  include/configs/cougarcanyon2.h           | 34 +++++++++++
>>  10 files changed, 256 insertions(+)
>>  create mode 100644 arch/x86/dts/cougarcanyon2.dts
>>  create mode 100644 board/intel/cougarcanyon2/Kconfig
>>  create mode 100644 board/intel/cougarcanyon2/MAINTAINERS
>>  create mode 100644 board/intel/cougarcanyon2/Makefile
>>  create mode 100644 board/intel/cougarcanyon2/cougarcanyon2.c
>>  create mode 100644 board/intel/cougarcanyon2/start.S
>>  create mode 100644 configs/cougarcanyon2_defconfig
>>  create mode 100644 include/configs/cougarcanyon2.h
>
> Acked-by: Simon Glass <sjg at chromium.org>
>
> A few nits though:
> - Include order - <asm/... should go after the normal includes
> - can we drop the calls to x86_pci_...? Please check it on top of the
> u-boot-dm/pcif-working series
>

Yep, I plan to do v2 after all your previous DM patches are applied.

Regards,
Bin


More information about the U-Boot mailing list